Skip to content

Conversation

@thebeambot
Copy link
Contributor

No description provided.

@thebeambot thebeambot requested a review from a team as a code owner July 8, 2024 12:41
.formatter.exs Outdated

[
import_deps: [],
import_deps: [:phoenix],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like common-config is not filtering out dev dependencies when considering dependencies for this list. Update upstream needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to get resolved. Digging in I didn't see an easy way to tell whether it was dev or not. Your feedback is welcomed as always @btkostner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably not a good way of doing this in shell or js just because of the parsing complexities and multi line formatting options. My move forward would be to change the script in common config to an elixir one off script that parses the mix.exs file and finds dependencies that way.

@thebeambot thebeambot force-pushed the gha/actions-sync branch 2 times, most recently from 669998e to ed0fd05 Compare March 11, 2025 17:36
@thebeambot thebeambot force-pushed the gha/actions-sync branch 7 times, most recently from 154d8c0 to 61cdabe Compare June 25, 2025 18:55
@thebeambot thebeambot force-pushed the gha/actions-sync branch 3 times, most recently from 598f1d3 to f95f437 Compare September 10, 2025 13:25
@thebeambot thebeambot force-pushed the gha/actions-sync branch 2 times, most recently from b68fd19 to d209265 Compare October 28, 2025 16:32
@thebeambot thebeambot force-pushed the gha/actions-sync branch 2 times, most recently from f4775ad to 89fe57b Compare November 10, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants